Problem/Motivation

The newly added Test in #3361028: Return a "real" Symfony 404 response object instead of mimicking it, revealed a couple of schema errors, which need to get fixed:

Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for search404.settings with the following errors: search404.settings:search404_use_customclue variable type is boolean but applied schema class is Drupal\Core\TypedData\Plugin\DataType\StringData, search404.settings:site_404 missing schema, search404.settings:search404_ignore_language missing schema

Steps to reproduce

Proposed resolution

Fix the schema and create an appropriate update hook.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 3362728-3.patch392 bytessamitk

Issue fork search404-3362728

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

samitk’s picture

samitk commented
Assigned: Unassigned » samitk
Status: Active » Needs work

I am working on it.

samitk’s picture

samitk commented
Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3362728-3.patch392 bytes

I have added the missing schema, Please review.

mitthukumawat made their first commit to this issue’s fork.

mitthukumawat’s picture

mitthukumawat commented

@samit.310@gmail.com
Added schema are fine, opened a MR against 2.x. It should not have the failed tests once changes merge together with Return a "real" Symfony 404 response object instead of mimicking it

mitthukumawat opened merge request !17

mitthukumawat’s picture

mitthukumawat commented
Status: Needs review » Reviewed & tested by the community

The schema error gone away with above MR so we can move this to RTBC.
We can refer #3361042: Create tests to test this modules functionality. for missing phpunit tests for entire module.

jijojoseph_zyxware made their first commit to this issue’s fork.

jijojoseph_zyxware’s picture

jijojoseph_zyxware commented
Status: Reviewed & tested by the community » Fixed

Merged to 2.x branch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.