Problem/Motivation

6.1.x doesn't have a release on the module page yet, but a test fails, see https://www.drupal.org/node/719864/qa

That should be fixed before tagging and publishing the release.

Ckeditor5.Drupal\Tests\linkit\FunctionalJavascript\LinkitDialogCKEditor5Test
✗
Drupal\Tests\linkit\FunctionalJavascript\LinkitDialogCKEditor5Test

fail: [Other] Line 0 of sites/default/files/simpletest/phpunit-3.xml:
PHPUnit Test failed to complete; Error: PHPUnit 9.6.7 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\linkit\FunctionalJavascript\LinkitDialogCKEditor5Test
F 1 / 1 (100%)

Time: 00:12.878, Memory: 4.00 MB

There was 1 failure:

1) Drupal\Tests\linkit\FunctionalJavascript\LinkitDialogCKEditor5Test::testLinkDialog
Failed asserting that true is false.

/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/var/www/html/modules/contrib/linkit/tests/src/FunctionalJavascript/LinkitDialogCKEditor5Test.php:173
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

FAILURES!
Tests: 1, Assertions: 17, Failures: 1.

HTML output was generated
http://php-apache-jenkins-drupal-contrib-694379/subdirectory/sites/simpl...
http://php-apache-jenkins-drupal-contrib-694379/subdirectory/sites/simpl...
http://php-apache-jenkins-drupal-contrib-694379/subdirectory/sites/simpl...
http://php-apache-jenkins-drupal-contrib-694379/subdirectory/sites/simpl...

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 3362578.6.1.x_3.patch1.41 KBmark_fullmer

Issue fork linkit-3362578

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Active » Needs review
StatusFileSize
new 3362578.6.1.x_3.patch1.41 KB

The attached patch updates the test logic to match the behavior of CKEditor 5 v36, which is used by Drupal core 10.1

  • mark_fullmer committed 456bdff0 on 6.1.x 
    Issue #3362578 by mark_fullmer, Anybody: Fix failing 6.1.x test
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.