The meta tags do not render in a reliable fashion - the should first be ordered by group, and then the tag's weight. This causes problems with some of the test coverage, e.g. a problem that has arisen in #2945817: Support JSON API, REST, GraphQL and custom normalizations via new computed field.

CommentFileSizeAuthor
#10 metatag-n3362522-10.patch7.9 KBdamienmckenna
#8 metatag-n3362522-8.patch7.1 KBdamienmckenna
#5 metatag-n3362522-4.patch4.93 KBdamienmckenna
#3 metatag-n3362522-3.patch4.08 KBdamienmckenna
#2 metatag-n3362522-2.patch3.56 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n3362522-2.patch3.56 KB

Does this work?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n3362522-3.patch4.08 KB

Slightly tidied.

The last submitted patch, 2: metatag-n3362522-2.patch, failed testing. View results

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n3362522-4.patch4.93 KB

Sort the Basic and Advanced groups first.

The last submitted patch, 3: metatag-n3362522-3.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 5: metatag-n3362522-4.patch, failed testing. View results

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3362522-8.patch7.1 KB

Hopefully this fixes the test failures.

Status: Needs review » Needs work

The last submitted patch, 8: metatag-n3362522-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3362522-10.patch7.9 KB

This might fix it?

  • DamienMcKenna committed 642a912d on 8.x-1.x 
    Issue #3362522 by DamienMcKenna: Fix meta tag output sort order.

  • DamienMcKenna committed 025eb161 on 2.0.x 
    Issue #3362522 by DamienMcKenna: Fix meta tag output sort order.
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Fix meta tag sort order for D9 output » Fix meta tag output sort order
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.