Creating this issue to make this module Drupal 10 compatible.

CommentFileSizeAuthor
#7 icons_d10-3360457-7.patch7.17 KBabhinavk
#6 icons-error.png40.13 KBrahul17
#4 Screenshot from 2023-05-16 10-28-36.png16.23 KBdineshkumarbollu
#2 icons_d10-3360457-2.patch6.08 KBabhinavk
#2 icons_drupal-check.txt3.35 KBabhinavk

Issue fork icons-3360457

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

AbhinavK created an issue. See original summary.

abhinavk’s picture

abhinavk commented
Assigned: abhinavk » Unassigned
Status: Active » Needs review
StatusFileSize
new icons_drupal-check.txt3.35 KB
new icons_d10-3360457-2.patch6.08 KB

I have created this patch which makes this module Drupal 10 compatible. Also fixed some drupal-check errors.

Please review this patch.

dineshkumarbollu made their first commit to this issue’s fork.

dineshkumarbollu’s picture

dineshkumarbollu commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2023-05-16 10-28-36.png16.23 KB

Hi

The patch#2 applied cleanly and upgrade status report shows 0 errors.

dineshkumarbollu opened merge request !3

rahul17’s picture

rahul17 commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new icons-error.png40.13 KB

Patch #2 is making this module D10 compatible but while testing functionality I am getting console error.
Uploading console error screenshot.

abhinavk’s picture

abhinavk commented
Status: Needs work » Needs review
StatusFileSize
new icons_d10-3360457-7.patch7.17 KB

I have fixed the console error in this new patch. Functionality should be working fine with this.

rahul17’s picture

rahul17 commented
Status: Needs review » Reviewed & tested by the community

Applied patch #7, console error is gone and functionality is working as expected. Upgrade status is showing D10 compatible.

Moving this to RTBC.

steven buteneers’s picture

steven buteneers commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nitebreed closed merge request !3