Problem/Motivation

We just had a new puzzle posted with tons of fun references:

https://www.crosswordplayground.com/puzzle/way-go

Unfortunately, the puzzle uses lowercase "down" and "across". Typically, "Down" or "D" is used, but we should allow lowercase for sure!

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 crossword-lowercase-3359154-2-FAIL.patch892 bytesdanflanagan8

Issue fork crossword-3359154

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

danflanagan8 created an issue. See original summary.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Status: Active » Needs review
StatusFileSize
new crossword-lowercase-3359154-2-FAIL.patch892 bytes

Here's a patch with a new test case. I also noticed a bug in two existing test cases. I think they will fail now as well. I can fix those at the same time.

keshav.k made their first commit to this issue’s fork.

keshavv’s picture

keshavv commented
Status: Needs review » Reviewed & tested by the community

Tested the patch, Confirmed that it is working perfect.
Created the MR for easy merge. Moving to RTBC.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Status: Reviewed & tested by the community » Needs work

@keshav.k, that's a fail test.

There's no fix.

You are lying. You clearly didn't test this.

Please stay out of the issue queue unless you are going to do real work.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented

  • danflanagan8 committed cc444587 on 2.0.x 
    Issue #3359154 by danflanagan8: Clue references should be case...
danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Status: Needs work » Fixed

I just pushed a fix that simplifies things by converting all text to uppercase before looking for the reference patterns. Because of the post-processing that was even easier than trying to use the i flag on the regex patterns.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.