Problem/Motivation

Not sure if this is a bug or intended design.
In claro or seven, the remove shortcut icon is highlighted to indicate the user 'This is already added to shortcut'.
Remove shortcut icon used
in claro
claro-filled-icon.png

in seven
seven-filled-icon.png

However GIN overrides remove icon with filled icon in High contrast mode. See line https://git.drupalcode.org/project/gin/-/blob/8.x-3.x/dist/css/base/gin.css#L592

Can we have this feature in normal mode as well?

Steps to reproduce

On a standard installation Drupal

  • Enable the Gin admin theme. (/admin/appearance/)
  • Make sure 'Increase contrast (EXPERIMENTAL)' is not checked. (/admin/appearance/settings/gin)
  • Goto content view. (/admin/content)
  • Try adding and removing this page to shortcuts
  • Check 'Increase contrast (EXPERIMENTAL)' to enable. (/admin/appearance/settings/gin)
  • Goto content view and try adding and removing page to shortcuts
CommentFileSizeAuthor
seven-filled-icon.png63.71 KBsahal_va
claro-filled-icon.png52.3 KBsahal_va

Comments

sahal_va created an issue. See original summary.

sahal_va’s picture

sahal_va commented
Issue summary: View changes

  • saschaeggi committed 1a80cd4d on 8.x-3.x 
    Issue #3358694: Displaying same icon for 'Add to shortcuts' and  'Remove...
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Active » Fixed

@sahal_va great idea 👍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.