Problem/Motivation
template_preprocess_html contains:
// @todo Remove once views is not bypassing the view subscriber anymore.
// @see https://www.drupal.org/node/2068471
elseif ($is_front_page) {
$head_title = [
'title' => t('Home'),
'name' => $site_config->get('name'),
];
}
That issue was closed. So we should be safe to remove that special case.
Proposed resolution
We probably need a test ensuring this. The test should create a view, set it as the home, and ensure the title is Home and not the views title.
Remaining tasks
Patch removing that code, test.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
None.
Issue fork drupal-3355678
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
penyaskitoI *think* this could be removed and there would be no effect.
Because if I set a view as the homepage, the homepage will already have that #title. So if we consider that a bug, the bug is already in core.
Comment #5
gauravvvv commentedComment #6
smustgrave commentedNeeds failure seems legit to this.
And as mentioned a test case showing this should be included. As removing it did break a test.
Comment #11
penyaskitoWhen I created this, I wrote the Proposed resolution as:
"The test should create a view, set it as the home, and ensure the title is Home and not the views title."
Which currently with HEAD is not even true.
If I create a view, set it as the home, the title won't be Home but the views title.
So we first need to define if that's the correct behavior.
Comment #12
penyaskito