Problem/Motivation

In #3123832: [META] Fix @todo items referencing closed issues we've discovered there's a @todo in \Drupal\Core\Routing\UrlGenerator::getRouteStringIdentifier.
This @todo is linked to an d.o. issue that is already closed: #3151019: Only allow route names, deprecate support for route objects in UrlGenerator methods.

This is the @todo:

   * @todo Remove in https://www.drupal.org/i/3151019

Steps to reproduce

Proposed resolution

#3151019: Only allow route names, deprecate support for route objects in UrlGenerator methods was closed, but has a follow-up issue for cleanup in D11: #3339710: Disallow passing route objects to UrlGenerator methods

Let's replace the link in the @todo with the latter one.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3354961

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Spokje created an issue. See original summary.

spokje’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Simple change.

longwave’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 3b7dc0f28b to 10.1.x. Thanks!

  • longwave committed 3b7dc0f2 on 10.1.x
    Issue #3354961 by Spokje: Update @todo comment in \Drupal\Core\Routing\...
longwave’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.