Lates Dev version (with automated D10 patch) is not compatible with drupal 10.
core_version_requirement: ^8 || ^9 also misses version 10Fresh install on D10.0.7 with colorbox
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | insert-3354931-drupal_10_compatibility-2.patch | 6.6 KB | snater |
| #2 | insert-3354931-drupal_10_compatibility.patch | 3.23 KB | snater |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !5changes, plain diff MR !4
Comments
Comment #2
snater commentedAttached a patch set that fixes the issues for me, although I just did some little testing if the Insert button shows up again and inserting an image basically works.
The core requirement would need to be bumped directly to version 10 without backward compatibility, because Twig has been upgraded to version 3 along with Drupal 10, which requires changes to be made in the template files. Drupal 9.2 had deprecated
hook_field_widget_form_alter, which is superseded byhook_field_widget_single_element_form_alter.Of course, the CKEditor legacy module has to be used as of now. As for upgrading the CKEditor dependency, there is a separate issue: https://www.drupal.org/project/insert/issues/3314446
Setting this ticket to major priority, which I'll also assign to the CKEditor issue to draw attention.
Comment #3
nitrocad commentedThanks for the patch.
I tested it too on D10.0.7 with CKE4 and Colorbox, and it seems working fine!
Once is missing, the submodules version requirement need to be updated too.
Comment #4
snater commentedThanks for checking. Forgot about the submodules, there is also another occurrence of
hook_field_widget_form_alter. Updated patch attached.Comment #5
mlncn commentedThis should probably get another major version branch release given the need to drop D9 support.
(And then another major version for CKeditor5?)
But it's needed now, obviously, for sites to move to Drupal 10.
Patch does that, and looks good!
Comment #11
snater commentedPatch is merged and 3.0.0 beta release is created.
If things are fine, will make a final 3.0.0 release within the next few weeks.
Thanks to everyone involved here.