During the make file build process we are seeing the warning below due to a missing library type key.
Undefined property: DrushMakeProject_Library::$type make.project.inc:165

CommentFileSizeAuthor
#2 undefined_property_drushmakeproject_library_type_fix-3354209-1.patch1.16 KBvimal_nadar

Comments

vimal_nadar created an issue. See original summary.

vimal_nadar’s picture

vimal_nadar commented
StatusFileSize
new undefined_property_drushmakeproject_library_type_fix-3354209-1.patch1.16 KB

I have added the 3 missing library types key to the make file.

vimal_nadar’s picture

vimal_nadar commented
Status: Active » Needs review
lesleyfernandes’s picture

lesleyfernandes commented
Status: Needs review » Reviewed & tested by the community

I reviewed that fix, and it is working fine. I am not seeing warnings here.

vimal_nadar’s picture

vimal_nadar commented
Issue tags: +PHP 8.0
vimal_nadar’s picture

vimal_nadar commented
Issue tags: -PHP 8.0
gausarts’s picture

gausarts commented
Category: Bug report » Task
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Thank you.

It was fine for years, and now broken?
May I know your setup for a repro?

Upstream breaking changes are never a bug, otherwise no projects would never reach any stability of their own. We should adapt to or update it as a Task instead.

Deep ponder mode. This file has caused a handful of issues this far. While this is useful to some devs, but it apparently costs more maintainance. I am thinking to remove it as I can no longer support things that cost me more maintainance that I can afford at least just as recently.

vimal_nadar’s picture

vimal_nadar commented

During the build process of a Drupal 7.95 version site with PHP 8.0, a warning message is displayed when installing this module using a make file, indicating a potential issue or warning related to PHP 8.0 compatibility.

vimal_nadar’s picture

vimal_nadar commented
Assigned: vimal_nadar » Unassigned
gausarts’s picture

gausarts commented
Status: Postponed (maintainer needs more info) » Postponed

Last time I tried PHP8 for D7, it was like opening a can of worms.
Too many modules incompatible to deal with.

This should be in, but let's postpone this till I can get back to it.

Thanks.

lesleyfernandes’s picture

lesleyfernandes commented

Hi gausarts,

This patch is promoting a simple change, and PHP 7.x has already reached EOL:
https://www.php.net/supported-versions.php

Reviewing the code using PHPCS to check if changes are required to make the code fully compatible with PHP 8.1+ would be nice.

  • gausarts committed 53f1866e on 7.x-2.x authored by vimal_nadar 
    Issue #3354209 by vimal_nadar, lesleyfernandes: Undefined property:...
gausarts’s picture

gausarts commented
Status: Postponed » Fixed

Got it! I said at #10: "This should be in, but let's postpone this till I can get back to it."

No biggies. Committed. Thank you for contribution and patience.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.