vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/taxonomy_custom_controller/

FILE: ...ib/taxonomy_custom_controller/src/EventSubscriber/RouteAlterSubscriber.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
15 | ERROR | [ ] Missing short description in doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...www/html/drupalvb/web/modules/contrib/taxonomy_custom_controller/README.md
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
14 | WARNING | [ ] Line exceeds 80 characters; contains 113 characters
16 | WARNING | [ ] Line exceeds 80 characters; contains 159 characters
28 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
76 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
88 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 448ms; Memory: 12MB

CommentFileSizeAuthor
#4 codingstandards-3354152-3.patch2.41 KBdineshkumarbollu
#2 codingstandards-3354152-2.patch2.41 KBdineshkumarbollu

Comments

dineshkumarbollu created an issue. See original summary.

dineshkumarbollu’s picture

dineshkumarbollu commented
Assigned: dineshkumarbollu » Unassigned
Status: Active » Needs review
StatusFileSize
new codingstandards-3354152-2.patch2.41 KB
niklan’s picture

niklan
Primary language Russian
Location Russia, Perm
commented
Status: Needs review » Needs work

Thank you for patch, but there are still some problems:

+    $build['view'] = views_embed_view(
+      'taxonomy_term',
+      'page_1',
+      $taxonomy_term->id()
+    );

The last argument should also have a comma in that case.

+ * {@inheritDoc}

It should be lowercase. {@inheritdoc}

dineshkumarbollu’s picture

dineshkumarbollu commented
Status: Needs work » Needs review
StatusFileSize
new codingstandards-3354152-3.patch2.41 KB

Hi Niklan

I change the lines which you suggest and creates a patch please review.

thanks

niklan’s picture

niklan
Primary language Russian
Location Russia, Perm
commented
Status: Needs review » Fixed

Committed, thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.