Problem/Motivation

When adding a tour with core's Tour module to a route that uses the frontend theme, the Tour module will not appear in the toolbar

Steps to reproduce

Enable Gin and Gin Toolbar
Install Tour module
Install contrib module "Tour UI" (for easier reproduction of bug)
Go to /admin/config/user-interface/tour/manage/tours
Add route "search.view_node_search"
Go to /search

Bug behavior:
Tour button does not show in toolbar

Correct behavior:
If you uninstall Gin Toolbar, you will see the Tour button appear in the core toolbar

Proposed resolution

Move toolbar related preprocessing / twig files from Gin theme to Gin Toolbar module (not tested)

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork gin-3353113

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

JurriaanRoelofs created an issue. See original summary.

saschaeggi’s picture

saschaeggi
he/him
commented
Project: Gin Toolbar » Gin Admin Theme
Version: 8.x-1.x-dev » 8.x-3.x-dev

saschaeggi opened merge request !292

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Active » Needs review
linhnm’s picture

linhnm commented
Status: Needs review » Reviewed & tested by the community

The MRs work well.
Moving to RTBC.
Thank you

jurriaanroelofs’s picture

jurriaanroelofs commented

Great! Works for me too thanks.

  • saschaeggi committed 78d579a4 on 8.x-3.x 
    Issue #3353113: Tour module button missing in frontend themes
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed

Great, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.