Need the module to be Drupal 10 ready

CommentFileSizeAuthor
#6 make-drupal-10-ready-3352897-3.patch1.87 KBramlev
#2 make-drupal-10-ready-3352897-2.patch441 bytesramlev

Issue fork commerce_payment_extra-3352897

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ramlev created an issue. See original summary.

ramlev’s picture

ramlev commented
StatusFileSize
new make-drupal-10-ready-3352897-2.patch441 bytes

Nishant made their first commit to this issue’s fork.

Nishant opened merge request !4

nishant’s picture

nishant
Primary language English
commented
Status: Active » Needs review
Issue tags: +features
ramlev’s picture

ramlev commented
StatusFileSize
new make-drupal-10-ready-3352897-3.patch1.87 KB

Updated patch

Yuraul made their first commit to this issue’s fork.

yuraul’s picture

yuraul commented

MR updated with changes from #6

zaporylie made their first commit to this issue’s fork.

esolitos made their first commit to this issue’s fork.

dlevchik made their first commit to this issue’s fork.

dlevchik’s picture

dlevchik commented
Issue tags: +Drupal 10 compatibility

Made a new commit fixing dispatcher dispatch() arguments order

kjankowski made their first commit to this issue’s fork.

kjankowski’s picture

kjankowski commented

I fixed all tests for PHPCS & PHPStan - seems ready for D10 now, can you review?

esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented
Status: Needs review » Reviewed & tested by the community

All changes make sense to me.

eiriksm made their first commit to this issue’s fork.

  • eiriksm committed 39abab5e on 8.x-1.x authored by Nishant 
    Issue #3352897 by Nishant, ramlev, kjankowski, dlevchik, Yuraul,...
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented

Comments seems to be addressed.

Not a huge fan of this MR also randomly including fixes to all kinds of coding standard things, but since others have reviewed it I will not complain about that :)

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.