Problem/Motivation

We finally have running tests on DrupalCI on D10, so lets fix the remaining issues.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 tmgmt-tests-fixes-10.1-3352099-5.patch3.17 KBberdir
#5 tmgmt-tests-fixes-10.1-3352099-4.patch2.47 KBberdir
#3 tmgmt-tests-fixes-10.1-3352099-3.patch2.41 KBberdir

Comments

Berdir created an issue. See original summary.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented

Hi I ran tests in my local drupal10 environment and they passed 

Testing /app/modules/contrib/tmgmt/tests/src/Functional
................                                                  16 / 16 (100%)

Time: 02:25.692, Memory: 10.00 MB

OK (16 tests, 750 assertions)

please can you tell me which is the issue subject?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new tmgmt-tests-fixes-10.1-3352099-3.patch2.41 KB

It's actually on 10.1 only and only since today, it's a regression caused by #3007424: Multiple usages of FieldPluginBase::getEntity do not check for NULL, leading to WSOD. This fixes it, but I guess the core issue will have to be reverted.

There are also hidden PHP deprecations though..

Status: Needs review » Needs work

The last submitted patch, 3: tmgmt-tests-fixes-10.1-3352099-3.patch, failed testing. View results

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new tmgmt-tests-fixes-10.1-3352099-4.patch2.47 KB

Right, mixed return type requires PHP 8, so adding the annotation instead until we require that.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new tmgmt-tests-fixes-10.1-3352099-5.patch3.17 KB

The other fail is caused by #3307509: No empty option for views bulk form, that seems sensible.

  • Berdir committed aab4b531 on 8.x-1.x 
    Issue #3352099 by Berdir: Fix D10 test fails
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Fix D10 test fails » Fix D10.1 test fails
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.