Problem/Motivation

When you enable the module, the method hook_help is not implemented.

Steps to reproduce

Download and activate the module and visit its help page.

Proposed resolution

Implement the hook_help and describe the functionality of the module and it's usage.

Remaining tasks

Implement hook_help.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#10 block_form_alter-3351438-10.patch1.67 KBnader.mouldi
#9 3351438-HelpPageFixed.png249.98 KBclarkssquared
#8 3351438-hook-help.png101.27 KBakshaydalvi212
#6 3351438-HelpPage.png150.29 KBclarkssquared
#6 3351438-after.png80 KBclarkssquared
#6 3351438-before.png76.31 KBclarkssquared

Issue fork block_form_alter-3351438

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dineshkumarbollu created an issue. See original summary.

dineshkumarbollu opened merge request !2

dineshkumarbollu’s picture

dineshkumarbollu commented
Assigned: dineshkumarbollu » Unassigned
Status: Active » Needs review
akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: Unassigned » akshaydalvi212
Status: Needs review » Needs work

The test failed and instead of putting the content line by line from README.md.
we can fetch the content from README.md directly.
I will update the MR.

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: akshaydalvi212 » Unassigned
Status: Needs work » Needs review

MR updated for implementing the hook_help().
kindly review.

clarkssquared’s picture

clarkssquared commented
Status: Needs review » Needs work
StatusFileSize
new 3351438-before.png76.31 KB
new 3351438-after.png80 KB
new 3351438-HelpPage.png150.29 KB

Hi akshaydalvi212

I applied your MR !2 in my local with Drupal 9.5.7 and confirmed that the hook_help() was implemented, but when I visit the help page, the page only says "Help is not available for this module"

Please look at the screenshot for your reference

For your review
Thank you.

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: Unassigned » akshaydalvi212

Thanks for the quick review,
I will work on it, update and push the code.

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: akshaydalvi212 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3351438-hook-help.png101.27 KB

updated the code and now it is working.
providing the screenshot as well.
kindly review.

clarkssquared’s picture

clarkssquared commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3351438-HelpPageFixed.png249.98 KB

Hi dineshkumarbollu

I applied the MR !2 commit bd8d7f06 in my local with Drupal 9.5.7 and confirmed that the hook_help() was implemented and the help page is now working

Please look at the screenshot for your reference

For your review
Thank you.

nader.mouldi’s picture

nader.mouldi commented
StatusFileSize
new block_form_alter-3351438-10.patch1.67 KB

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: block_form_alter-3351438-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

I will see it.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs work » Reviewed & tested by the community

Hi to be honest I don't know why test is failing I fixed it in my local environment 

PHPUnit 9.5.26 by Sebastian Bergmann and contributors.

Testing /app/modules/contrib/block_form_alter
.                                                                   1 / 1 (100%)

Time: 00:08.178, Memory: 10.00 MB

OK (1 test, 17 assertions)

I opened issue to see it .

As this issue is about just hook_help I'm moving to RTBC because hook_help is good.