Hello,

In my case, in need the background images to be in the pdf.
I made a patch for it but it might be useful to put a setting in the module to choose that.

CommentFileSizeAuthor
#6 3350900-6.patch1.44 KBbharath-kondeti
#2 3350900.patch592 bytesquentin massez

Issue fork entity_print_chrome-3350900

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Quentin Massez created an issue. See original summary.

quentin massez’s picture

quentin massez commented
StatusFileSize
new 3350900.patch592 bytes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs work

Thanks for the patch - I would prefer this to be a configuration option in the plugin, I think.

bharath-kondeti’s picture

bharath-kondeti commented
Assigned: Unassigned » bharath-kondeti

I will work on the issue and raise a patch.

bharath-kondeti opened merge request !1

bharath-kondeti’s picture

bharath-kondeti commented
Status: Needs work » Needs review
StatusFileSize
new 3350900-6.patch1.44 KB

Please review the attached patch. Thanks

bharath-kondeti’s picture

bharath-kondeti commented
Assigned: bharath-kondeti » Unassigned
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

  • longwave committed e7274098 on 1.0.x 
    Issue #3350900 by bharath-kondeti, Quentin Massez, longwave: Print...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.