Fix the issues reported by phpcs [#3350559]

Problem/Motivation

FILE: ~/projects/drupal-d10/modules/contrib/m4032404/src/Form/M4032404Form.php
---------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
---------------------------------------------------------------------
 12 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
 28 | ERROR   | [x] Short array syntax must be used to define arrays
 35 | ERROR   | [x] Short array syntax must be used to define arrays
---------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/m4032404/src/EventSubscriber/M4032404EventSubscriber.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
 80 | ERROR | [x] Short array syntax must be used to define arrays
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------

Time: 105ms; Memory: 10MB

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml m4032404

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork m4032404-3350559

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3350559-fix-the-issues changes, plain diff MR !2
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

27 March 2023 at 07:53

Rassoni created an issue. See original summary.

Comment #2

27 March 2023 at 07:58

Rassoni opened merge request !2

Comment #3

rassoni commented 27 March 2023 at 07:58

Status:

Active

» Needs review

Fixed Coding standard and created MR. Please review.

Comment #4

rassoni commented 27 March 2023 at 08:36

Assigned:

rassoni

» Unassigned

Comment #5

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 27 March 2023 at 13:47

Status:

Needs review

» Needs work

 /**
- * Class M4032404Form.
+ * Defines the m4032404 form.
  *
  * @package Drupal\m4032404\Form
  */

The description should be improved, since it is not clear what the m4032404 form should be.

Comment #6

rassoni commented 27 March 2023 at 14:17

Status:

Needs work

» Needs review

Thanks @apaderno, Addressed #5 feedback. Please review

Comment #7

a.aaronjake commented 20 August 2024 at 07:00

Status:

Needs review

» Needs work

Hi @Rassoni,

The changes you made on MR!2 can be applied successfully, but there are still errors reported. Please see below:

➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig m4032404

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/m4032404/tests/src/Unit/EventSubscriber/M4032404EventSubscriberTest.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\m4032404\EventSubscriber\M4032404EventSubscriber.
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/m4032404/tests/src/Functional/M4032404TestCaseTest.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
 18 | ERROR | [x] Whitespace found at end of line
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/m4032404/src/EventSubscriber/M4032404EventSubscriber.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------

Time: 182ms; Memory: 10MB

Please check

Thanks,
Jake