Problem/Motivation

MigrateForumTest uses the migrate_drupal test fixture instead of the forum one.

Steps to reproduce

Proposed resolution

Use \Drupal\Tests\forum\Kernel\Migrate\d6\MigrateForumTest::getFixtureFilePath in the test to get the correct fixture.

Remaining tasks

Patch
Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3350511-4.patch108.9 KBquietone
#4 interdiff-2-4.txt650 bytesquietone
#2 3350511-2.patch108.09 KBquietone
#2 3350511-2-no-fixture.patch614 bytesquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 3350511-2-no-fixture.patch614 bytes
new 3350511-2.patch108.09 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3350511-2.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-4.txt650 bytes
new 3350511-4.patch108.9 KB

The fixture change was to add 'Upload' so that needed a change in the Upgrade test as well.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

This is isolated to forum tests/fixtures so makes sense to me.

  • catch committed 48e05492 on 10.1.x 
    Issue #3350511 by quietone: Change MigrateForumTest to use forum test...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 48e0549 and pushed to 10.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.