When VBO actions are shown as buttons (e.g., "Display selectable actions as buttons." is enabled on the VBO field) then the buttons display twice at the bottom of the view. Appears one is the main element and the other is used as the sticky element. Alignment of buttons also differ between the two elements, the former is left aligned whereas the latter is right aligned.

CommentFileSizeAuthor
#4 gin-vbo-actions-twice-3349440.patch1.55 KBpiridium

Issue fork gin-3349440

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

greenSkin created an issue. See original summary.

saschaeggi’s picture

saschaeggi
he/him
commented
Title: VBO actions as buttons shows actions element twice » [VBO] Actions as buttons shows actions element twice
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Active » Closed (duplicate)

Closing in favor of #3387813: Actions duplicated at bottom of page with Gin

piridium’s picture

piridium commented
Status: Closed (duplicate) » Needs review
Related issues: +#3387813: Actions duplicated at bottom of page with Gin
StatusFileSize
new gin-vbo-actions-twice-3349440.patch1.55 KB

I am reopening this issue because I think we are better off solving this from gins side instead of vbos.

Gin changes the form display to flex and introduces order properties. In particular, the edit header gets order: 99, which causes it to be positioned at the end.
I suggest that this order parameter is removed.
In addition, I would remove the parameter justify-content: flex-end for the form-actions, because this causes the buttons in the header to be aligned to the right in contrast to the footer.

Please refer to the attached patch.

piridium’s picture

piridium commented
Related issues: -#3387813: Actions duplicated at bottom of page with Gin +#3387640: VBO actions duplicated in addition to panel
piridium’s picture

piridium commented
Related issues: +#3387813: Actions duplicated at bottom of page with Gin

Please excuse, I was not aware that I replaced a related issue instead of adding one.

j.young’s picture

j.young commented

The patch in #4 was working for me on Drupal 9.4.7 but after updating to 10.2.4 I am now only getting one set of buttons at the bottom of the page/view. In Drupal 9 they were at the top and bottom. I get the same results with or without the patch applied. This applies to custom views pages as well as admin/content, admin/people, etc. Any idea how we can restore the top of page buttons in Drupal 10?

j.young’s picture

j.young commented

Disregard this, I failed to notice that the actions pop up at the bottom when you make a selection. This is perfect!

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Needs review » Needs work

This needs an MR

pradhumanjain2311 made their first commit to this issue’s fork.

pradhumanjain2311 opened merge request !411

pradhumanjain2311’s picture

pradhumanjain2311 commented
Status: Needs work » Needs review
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Needs review » Closed (outdated)

As Drupal Core adapted Gin's flyout and only include buttons once in Core, I'll close this issue as outdated.