[PBF] Drupal 10 Support

I should release a Drupal 10 compatible version this year (before the end of life of D9). As soon as I have some times to work on. Or sooner if someone provides a working patch.

This is one of the few modules we need to update our site to D10.

Any update on any work done to support Drupal 10? I may have some time in a few weeks to help work on a patch. If something has already been started I can pick up from that.

You can start from and work on #3289037: Automated Drupal 10 compatibility fixes

We are depending on this module in our update. Will look into issues.

The attached patch provides D10 compatibility.

Ahead of a new release of this module, you can apply this patch using composer-drupal-lenient to allow you to upgrade to Drupal 10.

Hi

Tested the module no D10 compatible issues found, i am attaching D10 report.

Thanks

Added automated tests for D10.
Anybody have manually tested the module with the patch on D10 ?

Committed only to be able to run the D10 tests.

Drop support of Drupal 8, and run tests on the -dev version.

tests needs to be refactored. Optionnal parameters must be placed at the end (no required parameters placed after them)

Incoming patchs should be easier to review now. Keeping patch #8 in -dev branch

This patch attempts to get the tests running on PHP 8.0 by refactoring the method signature for a couple of the methods, placing the optional parameters last.

See https://php.watch/versions/8.0/deprecate-required-param-after-optional

This patch to get the tests running on PHP 8.0 by refactoring the method signatures in the test, and adds Drupal 10 compatibility by removing use of deprecated core theme, classy.

The last patch, #23, fixes some of the issues with the tests. However, it does look like a few tests are still failing because they are unable to count the number of results on the search page. My suspicion is that \Drupal\Tests\pbf\Functional\PbfBaseTest::checkSearchResults relies on classes provided by the classy theme that is no longer available and it needs to be updated with a new XPath.

@flocondetoile Do you have any idea what that xpath selector should be changed to?

I guess we should change first the $defautTheme in PbfBaseTest.php, as classy doesn't exists anymore as a core theme in D10

/**
   * {@inheritdoc}
   */
  protected $defaultTheme = 'classy';

We check this xpath

//ol[contains(@class, 'search-results')]/li

Olivero has the same markup because of web/core/themes/olivero/templates/dataset/item-list--search-results.html.twig. So Tests should pass with Olivero.

Stable9 has only this template web/core/themes/stable9/templates/dataset/item-list.html.twig. So with stable9 the xpath should be //ol/li I guess

Switching to Olivero looks the best way to get green testss

This patch includes an update to the theme used when testing and drops support for Drupal 8 which is EOL.

Tests pass latest patch.

Committed. A new release 8.x-1.4 has been published. Thanks everyone.