Problem/Motivation

I was attempting to installing this module in my local environment using PHP8 for a client whose Drupal 9 site is hosted on a platform that no longer supports PHP 7.

I was unable to get composer to find an installable set of packages using composer require drupal/config_pr:^1.0 -W.

Here's what I got for output:

[03/9/23 3:35:38]  > composer require 'drupal/config_pr:^1.0' -W

./composer.json has been updated

Running composer update drupal/config_pr --with-all-dependencies

Gathering patches from patch file.

Loading composer repositories with package information                                                 
Info from https://repo.packagist.org: #StandWithUkraine

Updating dependencies

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - drupal/config_pr 1.x-dev is an alias of drupal/config_pr dev-1.x and thus requires it to be installed too.
    - drupal/config_pr[dev-1.x, 1.0.0-alpha1, ..., 1.0.0] require knplabs/github-api ^2.10 -> satisfiable by knplabs/github-api[2.10.0, ..., 2.x-dev].
    - knplabs/github-api[2.12.0, ..., 2.x-dev] require php ^7.1 -> your php version (8.0; overridden via config.platform, actual: 8.0.26) does not satisfy that requirement.
    - knplabs/github-api[2.10.0, ..., 2.11.0] require php ^5.6 || ^7.0 -> your php version (8.0; overridden via config.platform, actual: 8.0.26) does not satisfy that requirement.
    - Root composer.json requires drupal/config_pr ^1.0 -> satisfiable by drupal/config_pr[1.0.0-alpha1, ..., 1.x-dev (alias of dev-1.x)].

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

It looks like there is a closed issue for how to install that github API package with PHP 8.0 support: https://github.com/KnpLabs/php-github-api/issues/1050

I'm curious if there is a plan to integrate this into the module?

Thanks!

Steps to reproduce

Attempt to install the module using composer in a Drupal 9 site on an env running PHP 8+.

Proposed resolution

Support a version of the github API so that this module can be installed in sites running on PHP 8+.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork config_pr-3347089

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jesconstantine created an issue. See original summary.

kopeboy’s picture

Interested as well 🙏🏻
Will this allow for a D10 release too? 😊

marcelovani’s picture

Title: Add support for PHP 8.* » Drupal 10 upgrade

Updated the description and added draft PR https://git.drupalcode.org/project/config_pr/-/merge_requests/1

  • marcelovani committed e427cd10 on 8.x-1.x
    Issue #3347089 by jesconstantine, kopeboy, marcelovani: Drupal 10...

marcelovani’s picture

I did the upgrade to Drupal 10 + PHP 8 + upgraded the Composer packages.
Github API is working fine, Gitlab needs more work.
Please help to test, if you can.
Thanks.

marcelovani’s picture

Status: Active » Needs review
marcelovani’s picture

Status: Needs review » Closed (duplicate)
marcelovani’s picture

Status: Closed (duplicate) » Closed (outdated)