It seems like this bug was introduced by the Project Update Bot in this commit https://git.drupalcode.org/project/entity_reference_preview/-/commit/d2c....

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tarekdj created an issue. See original summary.

tarekdj’s picture

Priority: Normal » Critical
Status: Active » Needs review
tarekdj’s picture

m4olivei made their first commit to this issue’s fork.

m4olivei’s picture

Status: Needs review » Reviewed & tested by the community

This looks great. I added a clean up to the same classes affected here where the project update bot added odd unnecessary things to the constructors.

Thanks for catching this! My bad for not seeing those with the last patch test. Lesson learned not to trust the changes the project update bot makes.

e0ipso made their first commit to this issue’s fork.

  • e0ipso committed 0838a5f8 on 1.x authored by tarekdj
    Issue #3346721 by tarekdj, m4olivei: Several usages of $this when not in...
e0ipso’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for this folks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.