Problem/Motivation

Module is not compatible with Drupal 10 for this moment.

  • The 'addtocal' library is depending on a deprecated library. The core/jquery.once asset library is deprecated in Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the core/once library instead.
  • Value of core_version_requirement: ^8 || ^9 is not compatible with the next major version of Drupal core.
  • The drupal/core requirement is not compatible with the next major version of Drupal. Either remove it or update it to be compatible.
CommentFileSizeAuthor
#8 drupal-10-compatibility-v3.patch2.51 KBbelazoth
#5 drupal-10-compatibility-v2.patch2.55 KBbelazoth
#2 drupal-10-compatibility.patch2.22 KBa.kovrigin

Issue fork addtocal-3345479

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

a.kovrigin created an issue. See original summary.

a.kovrigin’s picture

a.kovrigin commented
StatusFileSize
new drupal-10-compatibility.patch2.22 KB

Proivded patch fixes compatibility issues

a.kovrigin’s picture

a.kovrigin commented
a.kovrigin’s picture

a.kovrigin commented
belazoth’s picture

belazoth
Primary language English
commented
StatusFileSize
new drupal-10-compatibility-v2.patch2.55 KB

When scanning the module with the patch in #2 applied with the upgrade_status module, it mentioned that the dupal/core requirement in the composer.json was not compatible with the next major version. So I updated that file and added the change to the patch from #2

a_mitch made their first commit to this issue’s fork.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Needs work

@Belazoth, it's recommended to remove drupal/core dependency from composer.json and rely on the core_version_requirement constraint from the .info.yml file. 

diff --git a/composer.json b/composer.json
index 5d8a33b..7de3325 100644
--- a/composer.json
+++ b/composer.json
@@ -8,7 +8,7 @@
     "source": "https://git.drupalcode.org/project/addtocal"
   },
   "require": {
-    "drupal/core": "^8 || ^9",
+    "drupal/core": "^8 || ^9 || ^10",
     "spatie/calendar-links": "^1.7"
   },
   "suggest": {

Could you please do this change and I'll RTBC

belazoth’s picture

belazoth
Primary language English
commented
StatusFileSize
new drupal-10-compatibility-v3.patch2.51 KB

Thanks for letting me know @claudiucristea. I have updated the patch to remove the drupal/core line instead of updating it.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs work » Reviewed & tested by the community

This is ready. Could we kick this in and cut a release, please?

kescoto-thinkshout’s picture

kescoto-thinkshout commented
Status: Reviewed & tested by the community » Fixed

Rolled 3.0.0-beta1 for D10 compatibility.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.