I need the module in version 3.0.1 to be compatible with Drupal 10.

CommentFileSizeAuthor
#6 Screenshot from 2023-03-29 10-36-37.png166.45 KBAbhay Sharma
#4 PortD9-to-D10.patch2.04 KBvishal choudhary
#4 Screenshot from 2023-03-28 15-42-51.png41.19 KBvishal choudhary
#4 Screenshot from 2023-03-28 15-43-25.png35.47 KBvishal choudhary
#2 3344223-drupal-10-compatibility-1.patch1 KBjmaerckaert

Issue fork queue_unique-3344223

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jmaerckaert created an issue. See original summary.

jmaerckaert’s picture

jmaerckaert commented
StatusFileSize
new 3344223-drupal-10-compatibility-1.patch1 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3344223-drupal-10-compatibility-1.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vishal choudhary’s picture

vishal choudhary
Location Dharmshala
commented
StatusFileSize
new Screenshot from 2023-03-28 15-43-25.png35.47 KB
new Screenshot from 2023-03-28 15-42-51.png41.19 KB
new PortD9-to-D10.patch2.04 KB

I have Port this Contrib Module from drupal 9 to drupal 10. Please reviews the code. (I have fixed these issues with the help of the Drupal check command
vendor/mglaman/drupal-check/drupal-check modules/contrib/queue_unique/
Add Screenshots:
Apply Patch Screenshot and Module install in local-D10 Setup Screenshot and Patch file. Please review
Thanks!

vishal choudhary’s picture

vishal choudhary
Location Dharmshala
commented
Assigned: jmaerckaert » vishal choudhary
Abhay Sharma’s picture

Abhay Sharma commented
StatusFileSize
new Screenshot from 2023-03-29 10-36-37.png166.45 KB

Hi, Vishal I have Applied your Patch File on our local Drupal 10 Setup, And it Working Fine. I think this module is compatible with Drupal 10.
so, I attached the Screenshot of our locally Installed module.
Thanks.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs work » Reviewed & tested by the community

rtbc based on last comment

Vishal Choudhary opened merge request !2

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/tests/src/Kernel/UniqueQueueTest.php
@@ -144,20 +144,20 @@ class UniqueQueueTest extends KernelTestBase {
+/**
+ * Adds a queue item and stores it directly to the queue.
+ *
+ * This code mimics the code that was in UniqueDatabaseQueue::doCreateItem()
+ * before the update to sha2.
+ *
+ * @param string $name
+ *   The queue name.
+ * @param mixed $data
+ *   Arbitrary data to be associated with the new task in the queue.
+ *
+ * @return string|false
+ *   A unique ID if the item was successfully created. False otherwise.
+ */

This change seems uninstentional, and the indenting is not right here.

The change is small enough, but these comment changes iare not correct.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs work » Fixed

I merged this. I fixed the indentation of the docblock on commit.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support to Free Software projects furthers the Open Web, and makes Drupal stronger.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.