Problem/Motivation
- The
spacelesstag is deprecated since Twig 2.7, use the"spaceless"filter with the"apply"tag instead. - #3094493: Upgrade to Twig 3
- #3091378: Investigate \Drupal\Core\Template\TwigEnvironment::getTemplateClass(): check if it still provides value, and if so, contribute it upstream
Proposed resolution
- Use the apply tag from Twig, and pass the
spacelessfilter. - Change
{% spaceless %}to{% apply spaceless %} - Change
{% endspaceless %}to{% endapply %}
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ➖ Accessibility and Readability
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes and Update Helper on new feature change/addition
- ✅ Release varbase-9.0.12, varbase_bootstrap_paragraphs-9.0.11
Varbase update type
- ✅ No Update
- ➖ Optional Update
- ➖ Forced Update
- ➖ Forced Update if Unchanged
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Issue #3343681: Changed filter
spacelesstoapply spacelessandendapply. As spaceless was deprecated since Twig2.7
Comments
Comment #2
rajab natshahComment #5
rajab natshahComment #6
rajab natshahComment #7
rajab natshahComment #8
rajab natshah✅ Released varbase_bootstrap_paragraphs-9.0.11
Comment #9
rajab natshahComment #11
rajab natshah✅ Released varbase-9.0.12