Make the module ready for Drupal 10 (especially the version requirement).

CommentFileSizeAuthor
#4 iban-field-widget-d10.png63.04 KBarisen
#2 drupal-10-3343187-2.patch1.03 KBcbeier

Issue fork iban_field-3343187

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cbeier created an issue. See original summary.

cbeier’s picture

cbeier commented
StatusFileSize
new drupal-10-3343187-2.patch1.03 KB

First attempt for Drupal 10.

arisen’s picture

arisen
Location Goa, GMT +5:30
commented
Assigned: Unassigned » arisen
Status: Active » Needs review
arisen’s picture

arisen
Location Goa, GMT +5:30
commented
Assigned: arisen » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new iban-field-widget-d10.png63.04 KB

Reviewed the patch and applied on 2.0.x branch. Patch applies cleanly and module works as expected.

Testing steps:

  1. Cloned the project(branch 2.0.x) on a drupal 10 site.
  2. Applied the patch in #2.
  3. Checking patch modules/webform_iban_field/webform_iban_field.info.yml...
Checking patch iban_field.info.yml...
Applied patch modules/webform_iban_field/webform_iban_field.info.yml cleanly.
Applied patch iban_field.info.yml cleanly.
  4. Installed the module and functionality. Check screenshot.

Moving to RTBC.

urvashi_vora made their first commit to this issue’s fork.

urvashi_vora’s picture

urvashi_vora commented

Reviewed and tested the patch, works well for me as well.

LGTM, RTBC++

Committing the changes for helping the maintainer.

urvashi_vora opened merge request !2

kopeboy’s picture

kopeboy
Primary language Italian
Location Milan
commented

+1
Please provide a D10 release 🙏🏻

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Can the maintainers of this module please tag a drupal 10 compatible release?

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Reviewed & tested by the community » Fixed

Committed.
Next release will be D10 compatible.

indrapatil’s picture

indrapatil commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.