Problem/Motivation

\Drupal\Core\Extension\ModuleHandlerInterface::getImplementations() has been deprecated in D10, CR: https://www.drupal.org/node/3000490

Proposed resolution

Switch to new supported Drupal\Core\Extension\ModuleHandlerInterface::invoke*With()

CommentFileSizeAuthor
#2 3343024-2.patch594 bytesfenstrat

Issue fork hux-3343024

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fenstrat created an issue. See original summary.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Active » Needs review
StatusFileSize
new 3343024-2.patch594 bytes

Here's the update approach.

Will also push as a MR.

fenstrat opened merge request !14

dpi’s picture

dpi
Location Perth, Australia
commented

HuxModuleHandlerProxyTrait is intended as a hollow proxy to the inner (usually core) implementation. I think in this case we'd straight up remove the method.

I'm in favor of switching to a >=D10 -only support branch.

Only D9.4 and above will see trigger error now right? D10 users are not affected in any way (other than dead code) ?

dpi’s picture

dpi
Location Perth, Australia
commented
Version: 1.x-dev » 1.2.x-dev

  • dpi committed 42ab75aa on 1.2.x authored by fenstrat 
    Issue #3343024 by fenstrat, dpi: Additional D10 updates
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Fixed

as found in 1.2.0-rc1

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

Make sense, thanks @dpi!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.