Problem/Motivation

Module is incompatible with Drupal 10 only for core_version_requirement key in .info.yml

CommentFileSizeAuthor
#2 hook_post_action-d10-readiness-3342117-2.patch549 bytesnicoschi

Issue fork hook_post_action-3342117

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicoschi created an issue. See original summary.

nicoschi’s picture

nicoschi commented
StatusFileSize
new hook_post_action-d10-readiness-3342117-2.patch549 bytes

m4olivei made their first commit to this issue’s fork.

m4olivei opened merge request !1

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Active » Needs review

I've opened a merge request with the patch in #2. I've also added:

  • Remove core key in info file and restrict the version of 8 supported to ^8.8. Only <8.7.7 need it.
  • Added same changes to info file for hook_post_action_example.info.yml. Otherwise was getting errors and not able to use it in D10. Nice module to test functionality.
  • Fixed dependency namespacing while I was there. Resolves #3122364: Dependency namespacing in info.yml.
  • Fixed the example module log messages.

I've tested this on a stock 10.0.4 install by enabling the hook_post_action_example module, inserting/editing/deleting content and then verifying the expected log messages that the example module puts out. Everything looks good to me.

  • m4olivei committed 027077ad on 8.x-1.x 
    Issue #3342117 by m4olivei, nicoschi: Drupal 10 readiness
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Fixed

Merged to 8.x-1.x. Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.