Problem/Motivation

Drupal core and php

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tedbow created an issue. See original summary.

tedbow’s picture

Version: 8.x-2.x-dev » 3.0.x-dev
wim leers’s picture

Title: Update requirements for 3.x » [PP-1] Update requirements for 3.x
Status: Active » Postponed

The test failures here look like this:

Testing Drupal\Tests\automatic_updates\Build\CoreUpdateTest
FFFFF                                                               5 / 5 (100%)

Time: 01:57.671, Memory: 14.00 MB

There were 5 failures:

1) Drupal\Tests\automatic_updates\Build\CoreUpdateTest::testApi
COMMAND: COMPOSER_MIRROR_PATH_REPOS=1 composer require --update-with-all-dependencies "drupal/automatic_updates:@dev"
OUTPUT:
ERROR: ./composer.json has been updated
Running composer update drupal/automatic_updates --with-all-dependencies
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires drupal/automatic_updates @dev -> satisfiable by drupal/automatic_updates[dev-merge-request-699].
    - drupal/automatic_updates dev-merge-request-699 requires drupal/core ^10 -> found drupal/core[9.8.0] but it does not match the constraint.

… which is what I encountered a few weeks ago and opened #3337049: Assert no errors after creating the test project in ModuleUpdateTest for.

wim leers’s picture

Pushed a commit to see if my new theory (after #4) is correct: if it is correct, we should get past the composer errors, and instead we should start seeing failures when modules are being installed … 🤓

wim leers’s picture

Title: [PP-1] Update requirements for 3.x » Update requirements for 3.x
Status: Postponed » Needs work

Looks like my theory in #5 worked — that means I disproved my theory in #4 🤓 — this does not need to be postponed on #3337049: Assert no errors after creating the test project in ModuleUpdateTest anymore!

wim leers’s picture

Assigned: Unassigned » phenaproxima
Status: Needs work » Needs review

Hopefully that'll be green now! 🤞

Left to do: address the @todo in \Drupal\Tests\automatic_updates\Functional\AvailableUpdatesReportTest::assertVersionLink(). Assigning to @phenaproxima since he added that — it's not entirely clear to me what should happen there — I think the entire assertion method should be dropped and all calls to it, but that'd be equivalent to losing test coverage…

phenaproxima made their first commit to this issue’s fork.

phenaproxima’s picture

Assigned: phenaproxima » tedbow

Assigning to @tedbow for review.

I decided to keep assertVersionLink(), but changed it assertVersionIsListed() to more accurately reflect what it does. The Download link is no longer visible, which is a core change that core should be testing.

tedbow’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me if tests pass

phenaproxima’s picture

  • phenaproxima committed 6d81b03b on 8.x-2.x authored by tedbow
    Issue #3341708 by Wim Leers, tedbow, phenaproxima: Update requirements...
phenaproxima’s picture

Status: Reviewed & tested by the community » Fixed

  • phenaproxima committed 4e350a4c on 3.0.x authored by tedbow
    Issue #3341708 by Wim Leers, tedbow, phenaproxima: Update requirements...

  • phenaproxima committed 1d071464 on 8.x-2.x
    Revert "Issue #3341708 by Wim Leers, tedbow, phenaproxima: Update...
wim leers’s picture

Assigned: tedbow » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.