Problem/Motivation
Drupal core and php
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork automatic_updates-3341708
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
tedbowComment #4
wim leersThe test failures here look like this:
… which is what I encountered a few weeks ago and opened #3337049: Assert no errors after creating the test project in ModuleUpdateTest for.
Comment #5
wim leersPushed a commit to see if my new theory (after #4) is correct: if it is correct, we should get past the
composererrors, and instead we should start seeing failures when modules are being installed … 🤓Comment #6
wim leersLooks like my theory in #5 worked — that means I disproved my theory in #4 🤓 — this does not need to be postponed on #3337049: Assert no errors after creating the test project in ModuleUpdateTest anymore!
Comment #7
wim leersHopefully that'll be green now! 🤞
Left to do: address the
@todoin\Drupal\Tests\automatic_updates\Functional\AvailableUpdatesReportTest::assertVersionLink(). Assigning to @phenaproxima since he added that — it's not entirely clear to me what should happen there — I think the entire assertion method should be dropped and all calls to it, but that'd be equivalent to losing test coverage…Comment #9
phenaproximaAssigning to @tedbow for review.
I decided to keep assertVersionLink(), but changed it assertVersionIsListed() to more accurately reflect what it does. The Download link is no longer visible, which is a core change that core should be testing.
Comment #10
tedbowLooks good to me if tests pass
Comment #11
phenaproximaComment #13
phenaproximaComment #16
wim leers