Problem/Motivation

Issue #3289933 added compatibility with Drupal 10 to the Dev branch. Among the deprecations addressed was this one: Usage of symfony-cmf/routing dependency deprecated

As specified in that change record, the new Drupal-specific RouteObjectInterface was introduced in Drupal 9.1. This means that the TablefieldItem class is no longer compatible with Drupal 9.0.x and below, it will error in its isEmpty() method.

Proposed resolution

The versions of Drupal core that cannot be supported with this D10-compatible code are all already End of Life for some time now. The nice and easy resolution is to raise the required core version appropriately.

Issue fork tablefield-3340940

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bvoynick created an issue. See original summary.

bvoynick opened merge request !11

bvoynick’s picture

bvoynick
he/him
Primary language English
commented
Status: Active » Needs review
pcate’s picture

pcate commented
Status: Needs review » Needs work

The upgrade status modules lists the following additional change needed:

modules/contrib/tablefield/src/Plugin/Field/FieldType/TablefieldItem.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 223  │ Symfony\Cmf\Component\Routing\RouteObjectInterface::ROUTE_NA │
│ manually │      │ ME is deprecated and removed in Drupal 10. Use               │
│          │      │ Drupal\Core\Routing\RouteObjectInterface::ROUTE_NAME         │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘
bvoynick’s picture

bvoynick
he/him
Primary language English
commented
Status: Needs work » Needs review

@PCate double check that you are using the latest dev version, rather than the latest release.

  • bvoynick committed ff618119 on 8.x-2.x 
    Issue #3340940: Module lists Drupal 8...
guilherme-lima-almeida’s picture

guilherme-lima-almeida
Primary language Portuguese, Portugal
Location Lisbon
commented

Hi @bvoynick,

Already merge the changes to 8.x-2.x-dev.

Thanks for the fix.

guilherme-lima-almeida’s picture

guilherme-lima-almeida
Primary language Portuguese, Portugal
Location Lisbon
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.