@ccrawford91 started working on functional tests in https://git.drupalcode.org/project/prlp/-/tree/feature/functional-tests. I would love to get this reviewed, finished and committed.

CommentFileSizeAuthor
#7 interdiff_6_7.txt2.75 KBnorman.lol
#7 3339180-7.patch9.58 KBnorman.lol
#6 interdiff_3_6.txt7.63 KBnorman.lol
#6 3339180-6.patch9.58 KBnorman.lol
#4 3339180-3.patch8.02 KBnorman.lol

Issue fork prlp-3339180

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

leymannx created an issue. See original summary.

leymannx credited ccrawford91.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
StatusFileSize
new 3339180-3.patch8.02 KB
norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Status: Active » Needs review
norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
StatusFileSize
new 3339180-6.patch9.58 KB
new interdiff_3_6.txt7.63 KB

Fixed coding standards violations.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
StatusFileSize
new 3339180-7.patch9.58 KB
new interdiff_6_7.txt2.75 KB

leymannx opened merge request !6

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

After you installed Drupal locally with the following multi-liner:

mkdir my-drupal10-site && \
cd my-drupal10-site && \
ddev config --project-type=drupal10 --docroot=web --create-docroot && \
ddev start && \
ddev composer create "drupal/recommended-project:^10" -y && \
ddev composer require "drupal/core-dev:^10" --dev && \
ddev composer require "drush/drush:^11" && \
ddev drush -y site:install --account-name=admin --account-pass=admin

You can set up running tests locally by following this article:

https://mglaman.dev/blog/running-drupals-phpunit-test-suites-ddev

Now get the issue fork and fire tests:

mkdir -p web/modules/contrib && \
cd web/modules/contrib && \
git clone -b 3339180-add-functional-tests git@git.drupal.org:issue/prlp-3339180.git && \
ddev exec ./vendor/bin/phpunit -c web/core web/modules/contrib/prlp-3339180

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.