Hello,

Test Site : https://master-akyyir0zjrx0m7aawbcu0agi37p8pkjq.tugboatqa.com/admin/cont...
Account: admin
Password：admin

Can it have a description column

1

CommentFileSizeAuthor
#6 issue_2.png202.92 KBsandeepsingh199
#6 Issue_1.png204.25 KBsandeepsingh199
#2 Snipaste_2023-03-01_09-29-49.png22.76 KBmsn5158

Issue fork site_settings-3339113

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

msn5158 created an issue. See original summary.

msn5158’s picture

msn5158 commented
Title: I think it should not show the full content in the 'Value' column, If the content is very long. » Can it have a description column
Issue summary: View changes
StatusFileSize
new Snipaste_2023-03-01_09-29-49.png22.76 KB
bobi-mel’s picture

bobi-mel commented
Assigned: Unassigned » bobi-mel

bobi-mel opened merge request !8

bobi-mel’s picture

bobi-mel commented
Assigned: bobi-mel » Unassigned
Status: Active » Needs review

The possibility of adding a description to setting was added by me. Please check it.

sandeepsingh199’s picture

sandeepsingh199 commented
StatusFileSize
new Issue_1.png204.25 KB
new issue_2.png202.92 KB

Hi @bobi-mel, I review your patch in my local & found two issue.
1. Create Setting button will display in description column.
2. while adding data in description column (Description of the Site Settings.) , it's not saving.

Steps to Replicate : -

For Issue 1 :
1. Structure > Manage site Setting
2. Click on Add Site Setting Type button, fill some data and Save
3. Add any one field in Manage fields
4. Move to Content > Site Setting
5. here you can see the issue 1.

For Issue 2:
6. On the same page click on Create Setting button.
7. Add data on Description filed & Save
8. after save page will redirect to admin/content/site-settings
9. here you can see the issue 2.

If you want i can fix this issue, please let me know.

sandeepsingh199’s picture

sandeepsingh199 commented
Status: Needs review » Needs work
bobi-mel’s picture

bobi-mel commented
Assigned: Unassigned » bobi-mel
bobi-mel’s picture

bobi-mel commented
Assigned: bobi-mel » Unassigned
Status: Needs work » Needs review

Hi @SandeepSingh199 thanks for the feedback.
As for the first issue it really my mistake and I fixed it.
as for the second issue, I think you have already been using this module and have the saved settings in the DB. After applying the patch you need to run drush updb command to update the schema of DB because it doesn't have a field for saving the Description value.
Can you try to apply new my changes, double-check them, and add new feedback?

sandeepsingh199’s picture

sandeepsingh199 commented

Thanks @bobi-mel, Issue 1 is fixed now & Issue 2 is my fault, i haven’t run that drush updb command, now i run that & found Description filed data is Saving now. All looks good to me, we can move this to RTBC+1.

bobi-mel’s picture

bobi-mel commented

Hi @SandeepSingh199 thanks for the feedback.

scott_euser made their first commit to this issue’s fork.

scott_euser’s picture

scott_euser commented

Thanks! I did the following, can you check you are still happy with it?

  • Moved update hook to install file
  • Updated field description to explain more about its usage
  • Minor coding standards
bobi-mel’s picture

bobi-mel commented

@scott_euser
As for me, it looks better. Thanks for the review and improves

scott_euser’s picture

scott_euser commented
Status: Needs review » Fixed

Thanks all!

scott_euser’s picture

scott_euser commented

And thanks particularly to bobi-mel for doing the hard work on this one

bobi-mel’s picture

bobi-mel commented

You're welcome

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.