Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 plotly_js-3338951-3.patch17.73 KBmatio89
#2 plotly_js-3338951-2.patch10.1 KBmatio89

Issue fork plotly_js-3338951

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

matio89 created an issue. See original summary.

matio89’s picture

matio89 commented
StatusFileSize
new plotly_js-3338951-2.patch10.1 KB

Attached is the patch.
Please review and let me know.
Thanks

matio89’s picture

matio89 commented
StatusFileSize
new plotly_js-3338951-3.patch17.73 KB

Attached is an updated patch with DI injections and fixing phpcs/phpcbf notices.

matio89 opened merge request !1

daniel.moberly’s picture

daniel.moberly commented
Status: Active » Needs work

There's something wonky going on with the combination merge requests & patches here. Can you rebase this whole thing into either a git repository or a patch? I can't manage to apply the patch to your repository or to the dev branch

matio89’s picture

matio89 commented

@Daniel,
Can you give me the write access to commit/push, I'll create a Drupal 9 dev branch and fix conflicts.
Thanks,

daniel.moberly’s picture

daniel.moberly commented

Its done. Let me know if I can help!

matio89’s picture

matio89 commented
Status: Needs work » Fixed

Thanks, @Daniel. I pushed a 3.x dev branch, and It should be available.

matio89’s picture

matio89 commented
Status: Fixed » Closed (fixed)

matio89 closed merge request !1