Ludwig is the Composer alternative.

CommentFileSizeAuthor
#2 3335390-02.patch306 bytesdevad

Comments

devad created an issue. See original summary.

devad’s picture

devad commented
StatusFileSize
new 3335390-02.patch306 bytes

The integration is simple. This patch should do the job for both 2.2.x-dev and 2.1.x-dev branches.

devad’s picture

devad commented
Status: Active » Needs review
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

@devad Thanks.

I'm not familiar with Ludwig so had a look around, and at the issue here: #3174645: [LIST] Ludwig integrations in contrib modules to see what other modules are doing.

The first one I looked at in detail was SMTP: #3137440: SMTP - Ludwig integration and it required a follow-up issue to put the letter "v" before the version string here: #3177608: Ludwig.json file fix

I noticed the patch on this issue does not have a "v", so basically two requests:

1.- just want to make sure the patch is coded correctly and the "v" is not necessary.
2.- Link to some instructions on how to properly test these patches for all the maintainers who are unaware of Ludwig-based sites to quickly get on board and test the code that they'll have to maintain.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Needs review » Needs work
devad’s picture

devad commented
Status: Needs work » Needs review

Hi. Thanks for reply.

The letter "v" before the version string is not needed any more. The latest few Ludwig versions do not need it.

To test the Ludwig integration... apply the patch to your project and then follow the Installation and Usage Ludwig tutorial. If all libraries required by your module are reported as "Installed" and your module works as expected without the "Class not found" errors that's sufficient to confirm that Ludwig integration is successful.

mandclu’s picture

mandclu commented

The documentation page shows the "v" before the version strings as well, but documentation can certainly become outdated too. Is there some reference we can see to verify that this is no longer required?

devad’s picture

devad commented

Re #7.

it is not Ludwig standard any more to prefix version numbers with "v" since all non-numeric characters inside the version strings are gracefully ignored now. There is no harm if you do add the extra "v" prefix to the version number... but there is no need or recommendation for that any more.

This part of Ludwig code (src/PackageManager.php file) is added to the Ludwig 8.x-1.10 release.

    // Two versions of the same package are not possible.
    // If multiple providers require the same package
    // we keep the highest required version only, since it has
    // the best probability to work for all providers, and
    // it is the most secure. And we mark all lower package
    // versions as 'Overriden'.
    $loop1_packages = $packages;
    $loop2_packages = $packages;
    foreach ($loop1_packages as $loop1_name => $loop1_package) {
      foreach ($loop2_packages as $loop2_name => $loop2_package) {
        // Let's strip all non-numeric characters from the package
        // versions in order to compare them successfully.
        if (($loop2_package['name'] == $loop1_package['name']) && ($loop2_name != $loop1_name) && (preg_replace("/[^0-9.]/", "", $loop2_package['version']) < preg_replace("/[^0-9.]/", "", $loop1_package['version']))) {
          $packages[$loop2_name]['status'] = 'Overridden';
        }
      }
    }

Related commit: #3255883: Packages list improvements

  • mandclu committed 255d0a15 on 2.2.x 
    Issue #3335390 by devad: SVG Image Field - Add Ludwig integration
mandclu’s picture

mandclu commented
Status: Needs review » Fixed

I don't love the idea that this file specifies the patch release, as it would seem to mean we become responsible for keeping that up to date. That said, it looks like the library has been pretty stable for the last year or so. Merged in.

devad’s picture

devad commented

Great. Thank you @mandclu

I have added the SVG Image Field module to Ludwig ecosystem (list of projects with active Ludwig integration).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.