Problem/Motivation

As a developer, i want to have some automatic tests.

Steps to reproduce

Proposed resolution

Adding tests for following use cases

  • Place block
  • Preferences title
  • Disabled klaro
  • Exclude paths

Remaining tasks

We must first merge #3335246. Testing will not working with incorrect naming.

User interface changes

API changes

Data model changes

Issue fork simple_klaro-3335271

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Erik Seifert created an issue. See original summary.

Erik Seifert opened merge request !12

erik seifert’s picture

erik seifert commented
Assigned: erik seifert » Unassigned
Status: Active » Needs review
erik seifert’s picture

erik seifert commented
Issue summary: View changes
Parent issue: » #3335246: Config schema incorrect name
erik seifert’s picture

erik seifert commented
Related issues: +#3335275: Use klaro settings for excluded paths in block settings and add cache for render array
erik seifert’s picture

erik seifert commented

Following tests are included for now:

- Simple test for placing block
- Test for changing title
- Test for excluded paths
- Test for disabled klaro

Also i added all tests with cache behaviour and cache tags.

erik seifert’s picture

erik seifert commented
norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

The MR also contains changes to the schema file. Is this on purpose? Does this affect existing installs? Is an update hook necessary for existing installations?

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Title: Adding test for klaro configurations » Add tests
Category: Task » Feature request
erik seifert’s picture

erik seifert commented

See #3335246: Config schema incorrect name

erik seifert’s picture

erik seifert commented

The current schema files does not apply any schema on simple_klaro.settings. Update hook ist not needed here.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

Oh, ay ay ay 😅

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

I will review it.

erik seifert’s picture

erik seifert commented

Tests will be running if #3335275: Use klaro settings for excluded paths in block settings and add cache for render array is merged

erik seifert’s picture

erik seifert commented

I have some findings with the tests.

- Added none initiated plugin manager
- Add correct behavior for empty exclude_paths
- Better block rendering (Bypass if user has the permission)

erik seifert’s picture

erik seifert commented
Status: Needs review » Needs work
erik seifert’s picture

erik seifert commented
Status: Needs work » Needs review
erik seifert’s picture

erik seifert commented

@elber feel free to test.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

Nice work!

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Assigned: elber » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.