Closed (fixed)
Project:
Email Contact
Version:
2.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Jan 2023 at 07:05 UTC
Updated:
8 Feb 2023 at 11:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
jay jangid commentedCreated MR , please review.
Thank you.
Comment #6
nagy.balint commentedThanks!
Comment #7
renatog commentedLooking for the README.md template documentation: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...
I'm seeing some errors of the standards
1) Table of contents:
This one is the first one in the README.md file, and after that there is an "Introduction" with the description. For example in the Search API README that is used as example in the documentation: https://git.drupalcode.org/project/search_api/-/raw/8.x-1.x/README.md
2) Requirements
When there is no requirement the documentations says that the text should be
3) How to use
As mentioned at #3335089-7: hook_help function missing in .module file this part is optional but I think can be useful an example about "how to use" to help the CMS editors
Comment #9
renatog commented'
Comment #10
renatog commented'
Comment #11
renatog commentedMR with the improvements reported in the #7: https://git.drupalcode.org/project/email_contact/-/merge_requests/11
Comment #12
nagy.balint commentedActually I think, the previous is the correct order, see attached image.
Comment #13
renatog commentedYeah, you are right, good catch
I'll send a comment in the documentation explaining that, that the README linked as "example" is using an different order than have in the documentation and it can confuse the users reading the doc instead of helping
I just updated the MR, keeping this order as was before and I'm just including the "How to use" steps to help the users: https://git.drupalcode.org/project/email_contact/-/merge_requests/11
Thank you so much
Comment #14
nagy.balint commentedHi!
There seem to be some issues in the patch. There are multiple 1s.
Attached image.
Comment #15
jay jangid commentedThanks @nagy.balint for notify me.
Fixed issue , please review.
Comment #16
renatog commentedThe fix seems good for me. Thanks @jay-jangid
Comment #17
renatog commented@nagy.balint just to let you know, this is the syntax for Markdown with "numbered lists" you know?
Look that on this online editor https://markdownlivepreview.com/
In the left space paste this code:
The resul will be with the correct ordinal numbers
Example on screenshot:
As I can see the MD syntax support both
and
Both will render as ordinal in the FE
Honestly I think the first one is better because if we have a lot of items, we don't need to put all of them following the order, 1,2,3,4 etc
Just put 1,1,1,1 the MK will apply that automatically in the FE
But since in our case we have just few items I think this last update on MR is also working fine, so for this reason I put as RTBC
Comment #19
nagy.balint commentedThanks! I'm not using markdown often.