Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
webform_localization shows that webform is failing PHP 8.2 dynamic properties for $export_wordwrap on the webform_exporter class in includes/exporters/webform_exporter.inc
W✓ -createWebformTranslation
✓ -createStringTranslation
✗
__construct
exception: [Deprecated function] Line 18 of sites/all/modules/webform/includes/exporters/webform_exporter.inc:
Creation of dynamic property webform_exporter_delimited::$export_wordwrap is deprecated
exception: [Deprecated function] Line 18 of sites/all/modules/webform/includes/exporters/webform_exporter.inc:
Creation of dynamic property webform_exporter_delimited::$export_wordwrap is deprecated
....
several times
https://www.drupal.org/pift-ci-job/2569479
Steps to reproduce
See patch
Proposed resolution
See patch
Remaining tasks
See patch
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Comment | File | Size | Author |
---|---|---|---|
#12 | D7_webform_php8x2x_fix-3333988-12.patch | 410 bytes | joseph.olstad |
Comments
Comment #2
joseph.olstadComment #3
joseph.olstadComment #4
joseph.olstadComment #5
joseph.olstadI'm not 100% sure if this will fix the glitch however it won't cause a regression.
Comment #6
joseph.olstadComment #7
joseph.olstadComment #8
joseph.olstadComment #9
Liam MorlandTesting uses the latest full release tag. That is probably the problem. If this is still a problem after a new full release is made, please re-open.
I do not think this patch does anything because NULL is the default value.
Please do not RTBC your own patches.
Comment #10
joseph.olstadI see an RC release, but the automated testing will likely take the full release tag. Kind of surprised it doesn't take the dev. Maybe I can change the webform_localization.info file to use the dev release.The newest patch fixes the PHP 8.2 error.
Comment #11
joseph.olstad@Liam Morland
There's a typeo, my patch 12 fixes it
the property was defined as export_wordrap
it's missing the 'w' in 'wrap' this is why PHP 8.2 is FAILING in the webform_localization automated tests that rely on webform!
This line hasn't changed since 2015 commit was by Dan Chadwick 2015-02-27
fb70bc1850 (Dan Chadwick 2015-02-27 16:50:16 -0500 8) public $export_wordrap;
wordwrap is spelled with a W before the r
Comment #12
joseph.olstadthe property is misspelled.
Comment #13
joseph.olstadComment #15
Liam MorlandIt would be nice to have test coverage that would surface this.
Comment #16
joseph.olstadwebform_localization automated tests surfaced this , so yes there are automated tests
Comment #17
joseph.olstad@Liam Morland, just wondering, when is 4.25 going to be tagged and released?
Is the delay on webform 7.x-4.25 going to be two weeks?
It's been one week already.
Next saturday it will be two weeks since 7.x-4.25-rc2
Comment #18
Liam MorlandI usually make a full release once the RC is two weeks old with no release-blockers.
Comment #19
joseph.olstadLooking forward to the release, as maintainer of webfirm_localization , I want the tagged release to get the fixes that resolve the automated test results fixed that are still failing due to the spelling error of export_wordwrap
The automated tests use the previous tagged release that has the bug.
Comment #20
joseph.olstadThere's also two other automated test fails that are failing due to what appears to be changes between webform releases since 2018
when I triggered tests for PHP 8.2 compatibility fixes, it was the first time webform_localization tests had been run since 21 Mar 2019 at 12:26 EDT when they last succeeded 100%
no code changes were made in webform_localization however two tests failed january 2023 in all versions of PHP.
Previously PHP 5.3 was passing as recently as 21 Mar 2019 at 12:26 EDT however since then PHP 5.3 does not pass.
Comment #21
joseph.olstad@Liam Morland, it's been more than two weeks now, can you please push a full release tag including this PHP 8.2 fix?