Problem/Motivation

The module has a dependency on the domain_site_settings module to allow to replace the frontpage url. In the newer domain setup, there is no need for domain_site_settings as this could easily be done with domain_config from the domain module itself.

Steps to reproduce

Enable the module
Go to the admin/config/domain/domain_simple_sitemap/config settings page and see that you can not enable replace frontpage.

Proposed resolution

Remove the dependency on domain_site_settings and allow to work with domain_config.

Remaining tasks

Create patch
Review patch

User interface changes

-

API changes

-

Data model changes

-

Issue fork domain_simple_sitemap-3333939

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim-diels created an issue. See original summary.

tim-diels opened merge request !7

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Assigned: tim-diels » Unassigned
Issue summary: View changes
Status: Active » Needs review

Provided MR. Please review.

carolpettirossi’s picture

carolpettirossi commented
Status: Needs review » Reviewed & tested by the community

I've just tested the MR and it works as expected. No need for the domain_site_settings anymore =D

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Assigned: Unassigned » i-trokhanenko
Status: Reviewed & tested by the community » Patch (to be ported)

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Assigned: i-trokhanenko » Unassigned
Status: Patch (to be ported) » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.