Drupal Coding Standards Issues | phpcs [#3333709]

Problem/Motivation

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/config_pages.info.yml
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
----------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/config_pages.module
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------
155 | WARNING | Only string literals should be passed to t() where possible
159 | WARNING | Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/config_pages.tokens.inc
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
9 | WARNING | [x] Unused use statement
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/ConfigPagesAccessControlHandler.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------
30 | ERROR | [x] Inline control structures are not allowed
46 | ERROR | [x] Inline control structures are not allowed
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/ConfigPagesContextBase.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
19 | WARNING | Possible useless method overriding detected
-------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/Form/ConfigPagesTypeDeleteForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
17 | ERROR | [x] Expected "\Drupal\Core\Entity\EntityStorageInterfacegetQuery" but found
| | "\Drupal\Core\Entity\EntityStorageInterface::getQuery()" for @var tag in member variable comment
24 | ERROR | [ ] Missing parameter comment
24 | ERROR | [x] Data types in @param tags need to be fully namespaced
25 | ERROR | [x] Separate the @param and @throws sections by a blank line.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/Entity/ConfigPages.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------
97 | WARNING | [ ] Possible useless method overriding detected
211 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/Plugin/Condition/ConfigPagesValueAccess.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
------------------------------------------------------------------------------------------------------------------------------------------
58 | ERROR | [ ] Type hint "array" missing for $plugin_definition
120 | ERROR | [x] Use null coalesce operator instead of ternary operator.
128 | ERROR | [x] Use null coalesce operator instead of ternary operator.
133 | ERROR | [x] Use null coalesce operator instead of ternary operator.
170 | ERROR | [x] Each PHP statement must be on a line by itself
217 | ERROR | [x] list(...) is forbidden, use [...] instead.
237 | ERROR | [x] list(...) is forbidden, use [...] instead.
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------

FILE: ...Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/Plugin/views/argument_default/CurrentContext.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
49 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/Plugin/Block/ConfigPagesBlock.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------------------
25 | ERROR | [ ] Class property $entity_display_repository should use lowerCamel naming without underscores
25 | ERROR | [ ] Missing member variable doc comment
26 | ERROR | [ ] Class property $entity_type_manager should use lowerCamel naming without underscores
26 | ERROR | [ ] Missing member variable doc comment
139 | ERROR | [x] Use null coalesce operator instead of ternary operator.
152 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/Controller/ConfigPagesController.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------------------------------------------
30 | ERROR | [ ] Class property $ConfigPagesStorage should use lowerCamel naming without underscores
37 | ERROR | [ ] Class property $ConfigPagesTypeStorage should use lowerCamel naming without underscores
68 | ERROR | [x] Data types in @param tags need to be fully namespaced
160 | ERROR | [ ] Missing parameter type
162 | ERROR | [x] Whitespace found at end of line
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/ConfigPagesLoaderService.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------
83 | ERROR | [x] Use null coalesce operator instead of ternary operator.
90 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/ConfigPagesTypeForm.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
30 | ERROR | [x] Scope keyword "protected" must be followed by a single space; found 2
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/ConfigPagesStorage.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
25 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/Commands/ConfigPagesCommands.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------------------------------------
22 | ERROR | [ ] Parameter tags must be grouped together in a doc comment
33 | ERROR | [x] Separate the @param and @option sections by a blank line.
42 | ERROR | [ ] Type hint "null" missing for $context
80 | ERROR | [x] Separate the @param and @validate-module-enabled sections by a blank line.
85 | ERROR | [ ] Type hint "null" missing for $context
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/Command/SetValueCommand.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
12 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/Command/GetValueCommand.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
10 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/Routing/ConfigPagesRoutes.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
25 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/contrib10/drupal10/modules/contrib/config_pages/src/ConfigPagesForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------
82 | ERROR | [ ] Missing parameter comment
82 | ERROR | [x] Data types in @param tags need to be fully namespaced
314 | ERROR | [ ] The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#14	3333709-14.patch	28.68 KB	jeroent
#2	3333709-2.patch	17.71 KB	sahil.goyal

Issue fork config_pages-3333709

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3333709-drupal-coding-standards changes, plain diff MR !27
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

16 January 2023 at 07:34

sahil.goyal created an issue. See original summary.

Comment #2

sahil.goyal commented 16 January 2023 at 07:36

Status	File	Size
new	3333709-2.patch	17.71 KB

Comment #3

sahil.goyal commented 17 January 2023 at 04:00

Status:

Needs work

» Needs review

Comment #4

7 March 2023 at 14:25

shumer made their first commit to this issue’s fork.

Comment #5

shumer commented 7 March 2023 at 14:27

Assigned:	Unassigned	» shumer
Status:	Needs review	» Active
Issue tags:	-, -

Comment #6

7 March 2023 at 14:27

shumer opened merge request !27

Comment #7

7 March 2023 at 15:10

shumer committed 4ab73f3d on 8.x-2.x

Issue #3333709: Drupal Coding Standards Issues | phpcs

Comment #8

shumer commented 7 March 2023 at 15:10

Status:

Active

» Fixed

Comment #9

nicodh commented 15 March 2023 at 10:59

Status:

Fixed

» Needs work

Hi,

Why did you remove src/Command/{Set,Get}ValueCommand.php ?
You should re-add these command files or also delete console.services.yml because it breaks Drupal Console.

Comment #10

15 March 2023 at 11:04

shumer committed 573b141a on 8.x-2.x authored by sahil.goyal

Issue #3333709 by shumer, sahil.goyal: Drupal Coding Standards Issues |...

Comment #11

shumer commented 15 March 2023 at 11:05

That was an accidental. Thanks for noticing that.

Comment #12

shumer commented 15 March 2023 at 11:07

Status:

Needs work

» Fixed

Comment #13

nicodh commented 15 March 2023 at 11:29

Thanks!!

Comment #14

jeroent

Dutch

🇧🇪

commented 22 March 2023 at 14:58

Status:

Fixed

» Closed (fixed)

Status	File	Size
new	3333709-14.patch	28.68 KB

Drupal Coding Standards Issues | phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork config_pages-3333709

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

News items

Our community

Documentation

Drupal code base

Governance of community