Problem/Motivation

Due to core changes between 9.4.8 and 9.5.1, Drupal.ajax "done()" returns before loaded commands are done executing. Switching to "then()" resolves this problem in Drupal >=9.4 (or earlier).

Proposed resolution

- Replace "done()" with "then()" in pd_media_manager.js and other js files when Drupal.ajax is used

Issue fork pagedesigner-3332934

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pvbergen created an issue. See original summary.

pvbergen’s picture

pvbergen commented
Issue summary: View changes

pvbergen opened merge request !45

pvbergen’s picture

pvbergen commented
Status: Active » Needs review

pvbergen opened merge request !48

  • pvbergen committed 0ac2f4c3 on 2.0.x 
    Issue #3332934 by pvbergen: pd_media_manager uses done() instead of then...

  • pvbergen committed 0ac2f4c3 on 2.x 
    Issue #3332934 by pvbergen: pd_media_manager uses done() instead of then...
pvbergen’s picture

pvbergen commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.