Problem/Motivation

Drupal 10 is close, we should check if 3.x is Drupal 10 compatible and tag a new stable release.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 3326183_d10_5.patch424 bytesjaroslav červený

Issue fork photoswipe-3326183

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

Katarzyna_Starzynska made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Drupal 10 is out, so this is major.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@Katarzyna_Starzynska nice try to catch credits. Reported you as spammer.

jaroslav červený’s picture

jaroslav červený commented
StatusFileSize
new 3326183_d10_5.patch424 bytes

Only changed version in info file.

Phototoswipe worked for me:

Drupal 10.0.0
PHP 8.1.13
MaraDB

here is patch.

grevil’s picture

grevil commented
Status: Active » Needs work

Might be true for the general module, but the drush implementation is deprecated.

grevil’s picture

grevil commented

Although this has nothing to do with the Drupal 10 compability, so you are correct! :)

grevil’s picture

grevil commented
Status: Needs work » Needs review

OK found a few more necessary entries in the test submodules.

I also created an issue regarding the drush command file, as it isn't necessary any more: #3328239: Necessity of old drush commands.

Grevil opened merge request !63

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

@Grevil: LGTM, please see the two review comments, then this can be merged and 3.2.3 can be released.

grevil’s picture

grevil commented
Status: Needs work » Needs review

Fixed.

grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

Tests are green!

  • Grevil committed c8f680af on 3.x 
    Issue #3326183: Drupal 10 compatibility fixes
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Released in 3.2.3!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.