Problem/Motivation

Getting following error/warnings

FILE: /app/modules/contrib/queue_ui/src/Commands/QueueUiCommands.php
-------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------
214 | WARNING | Redeclaration of function parameter $batch as variable.
-------------------------------------------------------------------------

FILE: /app/modules/contrib/queue_ui/src/Form/ItemDetailForm.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
75 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
-------------------------------------------------------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/queue_ui/src/Form/OverviewForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
225 | WARNING | Unused variable $queue_ui.
----------------------------------------------------------------------

Time: 1.18 secs; Memory: 12MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/queue_ui/

Proposed resolution

Above error/warnings need to be fixed

CommentFileSizeAuthor
#2 3325476-2.patch1.94 KBsamitk

Issue fork queue_ui-3325476

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

samit.310@gmail.com created an issue. See original summary.

samitk’s picture

samitk commented
Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3325476-2.patch1.94 KB

Issue fixed.

atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate

Hi,
I will review this issue.

Status: Needs review » Needs work

The last submitted patch, 2: 3325476-2.patch, failed testing. View results

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

Please create the MR with changes from the patch

voleger opened merge request !28

  • voleger committed 2ce39f4b on 3.1.x 
    Issue #3325476 by voleger, samit.310@gmail.com: Drupal Coding Standards...
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Needs work » Fixed

Fixed, thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.