Problem/Motivation

The Placeholder setting on Text area (multiple rows) form widgets currently uses a text field to enter its value. This isn't ideal for longer placeholders: the maximum amount of characters is 128 and it's displayed on one line, while the text will wrap if used as placeholder on the text area.

Steps to reproduce

Change the settings of a Text area (multiple rows) widget on an entity form display page.

Screenshot

Proposed resolution

Change the type of the form element from textfield to textarea.

Screenshot

Issue fork drupal-3325368

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

DieterHolvoet created an issue. See original summary.

dieterholvoet’s picture

Status: Active » Needs review

Rajeshreeputra made their first commit to this issue’s fork.

gaurav-mathur’s picture

StatusFileSize
new26.1 KB
new53.75 KB

Change the type of the form element from textfield to textarea succesfully in drupal10.1, Refer to the sreenshot .
Thank you

dieterholvoet’s picture

Status: Needs review » Reviewed & tested by the community

  • xjm committed 3fe52ad0 on 10.1.x
    Issue #3325368 by DieterHolvoet, gaurav-mathur: Use text area for the...
xjm’s picture

Status: Reviewed & tested by the community » Fixed

@gaurav-mathur, thanks for manually testing the patch. Note that there were already screenshots of this change in the issue summary and generally we don't give credit for duplicate screenshots, but in this case it's helpful since the original screenshots were from the original author, and I can now compare the two rather than manually testing it myself. In the future, I suggest embedding your screenshots in your comment with the <img> tag to make it easier for reviewers.

@Rajeshreeputra, I've removed credit for unnecessary rebasing/merging of HEAD; the original commit still applies just fine to my codebase.

For once, I don't think this issue really needs anything else. We don't test the specific input types used on forms (obviously, since nothing failed when we changed this), and there's no docs or CSS changes to worry about either. The UX improvement is obvious and does not require usability review. It's too small a change to require a change record.

Committed to 10.1.x as a user interface improvement. (As a UI change, it is not eligible for backport to the production branches.) Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.