Problem/Motivation

Instantiation of flag action plugins are not possible, as the constructor requires the flag ID and flag action to be set. This makes a generic instantiation impossible, for example at other components where a generic instantiation is performed.

Since any other action plugin I know of can be instantiated without any specific configuration defined, this looks like a bug.

Steps to reproduce

Proposed resolution

The action plugin deriver for flagging actions already contain by definition the flag ID and flag action, therefore it looks like that a sepecific configuration is not required to be passed, and thus could be instantiated if the plugin itself uses that information directly from the definition.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork flag-3322747

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mxh created an issue. See original summary.

mxh’s picture

Status: Active » Needs review

Berdir made their first commit to this issue’s fork.

  • Berdir committed 9e12a60 on 8.x-4.x authored by mxh
    Issue #3322747 by mxh: Action plugins cannot be instantiated in a...
berdir’s picture

Status: Needs review » Fixed

Merged, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.