We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.

Now that we've moved to GitLab, we should probably use Markdown instead of plain .txt files for our documentation.

CommentFileSizeAuthor
#19 Screenshot from 2023-06-13 17-25-00.png98.35 KBnitin_lama
#12 3322074-Applying-MR1.png17.89 KBclarkssquared
#4 3322074-Applying-Patch.png9.67 KBclarkssquared
#2 3322074-2.patch2.02 KBpanwarjatin

Issue fork field_group_metadata-3322074

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

panwarjatin created an issue. See original summary.

panwarjatin’s picture

panwarjatin commented
Status: Active » Needs review
StatusFileSize
new 3322074-2.patch2.02 KB

Changed README.txt to README.md please review it.

Thank you.

Bushra Shaikh’s picture

Bushra Shaikh commented

I applied patch#2 on the Drupal 10.0 version, but got the below error:

error: patch failed: README.txt:24
error: README.txt: patch does not apply
clarkssquared’s picture

clarkssquared commented
Status: Needs review » Needs work
StatusFileSize
new 3322074-Applying-Patch.png9.67 KB

Hi panwarjatin,

I also applied patch #2 on Drupal v9.5.9 and I also encountered the same error that Bushra Shaikh encountered as I applied the patch.

Please look at the screenshot attached for your reference.

Thank you

dineshkumarbollu made their first commit to this issue’s fork.

dineshkumarbollu opened merge request !1

dineshkumarbollu’s picture

dineshkumarbollu commented
Status: Needs work » Needs review
Bushra Shaikh’s picture

Bushra Shaikh commented

I applied patch#7 on the Drupal 10.0 version, but got the below error:

error: patch failed: README.txt:19
error: README.txt: patch does not apply
error: composer.json: already exists in working directory
error: field_group_metadata.info: No such file or directory
error: field_group_metadata.info.yml: already exists in working directory
error: patch failed: field_group_metadata.module:10
error: field_group_metadata.module: patch does not apply
error: src/FieldGroupMetadataPreRenderer.php: already exists in working directory
Bushra Shaikh’s picture

Bushra Shaikh commented
Status: Needs review » Needs work
dineshkumarbollu’s picture

dineshkumarbollu commented

please review the MR!1

Thanks

dineshkumarbollu’s picture

dineshkumarbollu commented
Status: Needs work » Needs review
clarkssquared’s picture

clarkssquared commented
Status: Needs review » Needs work
StatusFileSize
new 3322074-Applying-MR1.png17.89 KB

Hi dineshkumarbollu

I applied your MR!1 in my local and I can still see errors which fails the patch to be applied.

Please look at the screenshot attached for your reference

Thank you.

dineshkumarbollu’s picture

dineshkumarbollu commented

Hi

I will look on this.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama

Working on this, since this issue is not updated from past 15 days.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review

Please review. Updated README.md as per README.md Template.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
Bushra Shaikh’s picture

Bushra Shaikh commented
Status: Needs review » Needs work

I applied MR !1 and got below errors:

error: patch failed: README.txt:1
error: README.txt: patch does not apply
error: composer.json: already exists in working directory
error: field_group_metadata.info: No such file or directory
error: field_group_metadata.info.yml: already exists in working directory
error: patch failed: field_group_metadata.module:10
error: field_group_metadata.module: patch does not apply
error: src/FieldGroupMetadataPreRenderer.php: already exists in working directory
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs work » Needs review

Hi changes in MR are working fine to me.

Waiting another person to revise it.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
StatusFileSize
new Screenshot from 2023-06-13 17-25-00.png98.35 KB

MR Patch applies cleanly.

validation

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs review » Reviewed & tested by the community

Thank you @nitin_lama moving to RTBC.

  • florianmuellerch committed acdb8024 on 8.x-1.x 
    Issue #3322074 by dineshkumarbollu, nitin_lama, panwarjatin: Replace...

florianmuellerch’s picture

florianmuellerch
Primary language German
Location Aarau, Switzerland
commented
Status: Reviewed & tested by the community » Fixed

I want to apoligize for my late reaction, I was not aware that having a README.md is of some significance.
I used your patches and MRs and altered the readme a bit to represent recent changes.

Please use version 2.0 to use the commited changes.

Thank you very much for your work!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.