Problem/Motivation

Generally speaking, DSN is allowed to be null as a way to disable Sentry. So, let's avoid throwing a TypeError if the public_dsn config is null.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 3321670.patch639 bytesmfb
#2 3321670.patch2.31 KBmfb

Comments

mfb created an issue. See original summary.

mfb’s picture

mfb
they or he
commented
Status: Active » Needs review
StatusFileSize
new 3321670.patch2.31 KB
mfb’s picture

mfb
they or he
commented
StatusFileSize
new 3321670.patch639 bytes

  • mfb committed 78d706c on 3.x 
    Issue #3321670 by mfb: Don't throw TypeError if public_dsn is null
  • mfb committed 1eebed1 on 4.x
    Issue #3321670 by mfb: Don't throw TypeError if public_dsn is null

  • mfb committed d92d53a on 7.x-4.x 
    Issue #3321670 by mfb: Don't throw TypeError if public_dsn is null
mfb’s picture

mfb
they or he
commented
Status: Needs review » Fixed

  • mfb committed 21b3bc2 on 7.x-4.x 
    Issue #3321670 by mfb: Simplify logic

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.