Problem/Motivation

https://github.com/getsentry/sentry-php/pull/1428 makes traces_sample_rate nullable and changes the default from 0 to null. So we should allow it to be set to 0, and document the difference between 0 and null.

CommentFileSizeAuthor
#2 3320921.patch2.71 KBmfb
tracesSampleRate.patch2.77 KBmfb

Comments

mfb created an issue. See original summary.

mfb’s picture

mfb
they or he
commented
StatusFileSize
new 3320921.patch2.71 KB

Improve config descriptions

  • mfb committed 3a58692 on 4.x 
    Issue #3320921 by mfb: Apply tracesSampleRate if set to 0 and document...

  • mfb committed 6ceb60d on 3.x 
    Issue #3320921 by mfb: Apply tracesSampleRate if set to 0 and document...
mfb’s picture

mfb
they or he
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.