We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.

Now that we've moved to GitLab, we should probably use Markdown instead of plain .txt files for our documentation

CommentFileSizeAuthor
#14 README.d-updated-MR5.png305.12 KBclarkssquared
#14 3319944-applying-MR-updated.png91.79 KBclarkssquared
#11 3319944-after.png295.29 KBclarkssquared
#11 3319944-applying-MR.png185.17 KBclarkssquared
#11 3319944-before.png250.09 KBclarkssquared
#2 3319944-2.patch2.29 KBnitapawar

Issue fork config_rewrite-3319944

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nitapawar created an issue. See original summary.

nitapawar’s picture

nitapawar commented
Status: Active » Needs review
StatusFileSize
new 3319944-2.patch2.29 KB
Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs review » Reviewed & tested by the community

Reviewed this patch.
#2 patch looks good to me.
Found nil error.
can be moved to RTBC.

Sonal Gyanani’s picture

Sonal Gyanani commented
Version: 8.x-2.x-dev » 8.x-1.x-dev
Assigned: nitapawar » Sonal Gyanani

Sonal Gyanani opened merge request !5

Sonal Gyanani’s picture

Sonal Gyanani commented
Assigned: Sonal Gyanani » Unassigned
Status: Reviewed & tested by the community » Needs review

Fixed formatting issue according to Readme.md template format.
Please review.
Thanks

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs review » Needs work
Manoj Raj.R’s picture

Manoj Raj.R commented

Fixed some fixes which has other module reference.

Please review.

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs work » Needs review
nupur badola’s picture

nupur badola commented

Issue is still exists in the patch.

git.drupalcode.org_project_config_rewrite_-_merge_requests_5.diff.txt:9: trailing whitespace.
The Configuration Rewrite module rewrites existing configuration on module
git.drupalcode.org_project_config_rewrite_-_merge_requests_5.diff.txt:11: trailing whitespace.
in the config directory. Stops with an error, if you are going to rewrite
git.drupalcode.org_project_config_rewrite_-_merge_requests_5.diff.txt:15: trailing whitespace.
This can be handy, if you like to overwrite existing configuration
git.drupalcode.org_project_config_rewrite_-_merge_requests_5.diff.txt:17: trailing whitespace.
use install or update hooks. You can just place your configuration
git.drupalcode.org_project_config_rewrite_-_merge_requests_5.diff.txt:19: trailing whitespace.
module folder. Afterwards the existing configuration will be rewritten
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
clarkssquared’s picture

clarkssquared commented
Status: Needs review » Needs work
StatusFileSize
new 3319944-before.png250.09 KB
new 3319944-applying-MR.png185.17 KB
new 3319944-after.png295.29 KB

Hi

I also encountered the same issue as I tried to apply MR !5 to my local.

config_rewrite git:(8.x-1.5) curl https://git.drupalcode.org/project/config_rewrite/-/merge_requests/5.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3642 0 3642 0 0 1078 0 --:--:-- 0:00:03 --:--:-- 1082
:9: trailing whitespace.
The Configuration Rewrite module rewrites existing configuration on module
:11: trailing whitespace.
in the config directory. Stops with an error, if you are going to rewrite
:15: trailing whitespace.
This can be handy, if you like to overwrite existing configuration
:17: trailing whitespace.
use install or update hooks. You can just place your configuration
:19: trailing whitespace.
module folder. Afterwards the existing configuration will be rewritten
Checking patch README.md...
Checking patch README.txt...
Applied patch README.md cleanly.
Applied patch README.txt cleanly.
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
➜ config_rewrite git:(8.x-1.5) ✗

However, the patch successfully replaced the README.txt file with README.md, hence I will move this to needs work to cater the whitespace errors being flagged in the MR !5 patch

Please look at the screenshots attached for your reference

Thank you

bharath-kondeti made their first commit to this issue’s fork.

bharath-kondeti’s picture

bharath-kondeti commented
Status: Needs work » Needs review
clarkssquared’s picture

clarkssquared commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3319944-applying-MR-updated.png91.79 KB
new README.d-updated-MR5.png305.12 KB

Hi

I applied the updated MR !5 to my local and confirmed that the patch applied cleanly without the whitespace error, and README.txt was replaced with README.md file, hence the patch is good and functional.

Please look at the screenshot attached for your reference, moving this to RTBC

Thank you