Problem/Motivation

.ui_examples.yml can become huge and hardly maintenable.

Proposal

Instead of just lookign for {extension_id}.ui_examples.yml, we can look for any *.ui_examples.yml file in the extension (module or theme) and merge the plugin definitions lists, like what ui_patterns is doing.

No compatibility breaking changes.

Performance issue?

Issue fork ui_examples-3319243

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hi,

I don't think there will be performance issue and if any, we are talking about examples for the site builders/developers, so I don't think it will have a lot of impact.

Also do you intend to handle files in any subfolders too? So we can place the examples in an "examples" or "ui_examples" folder for better organization?

pdureau’s picture

pdureau commented

Also do you intend to handle files in any subfolders too? So we can place the examples in an "examples" or "ui_examples" folder for better organization?

Indeed, it is in the scope of this issue.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs work

Hi,

See my review comments.

Also please do not merge. You have not used the expected Git workflow, so no proper MR in the issue and so not triggering existing tests. And commits message are not standard.

pdureau opened merge request !11

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: pdureau » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Title: Allow splitiing of *.ui_examples.yml between many files » Allow spliting of *.ui_examples.yml between many files

  • Grimreaper committed 2d278787 on 1.x authored by pdureau 
    Issue #3319243 by pdureau, Grimreaper: Allow spliting of *.ui_examples....
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.