Problem/Motivation

An AJAX HTTP error occurred. HTTP Result Code: 500 Debugging information follows. Path: https://audiorents.com/update.php?op=selection&token=5kpotmePyYYm1NSnmJc... StatusText: error ResponseText: Error: Call to undefined function visitors_is_ip_valid() in visitors_update_7140() (line 157 of /home/audior10/public_html/sites/all/modules/visitors/visitors.install).

Steps to reproduce

update 7.12 to 7.14 apply db update

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 3318816-update-fail-6.patch1.37 KBbluegeek9
#2 Status report _ Audio Rents.pdf116.73 KBjg352
Screen Shot 2022-11-02 at 7.09.48 PM.png389.11 KBjg352
Screen Shot 2022-11-02 at 7.10.12 PM.png428.26 KBjg352

Issue fork visitors-3318816

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jg352 created an issue. See original summary.

jg352’s picture

jg352 commented
Title: install fail » install update fails
StatusFileSize
new Status report _ Audio Rents.pdf116.73 KB
bluegeek9’s picture

bluegeek9 commented
Assigned: Unassigned » bluegeek9

Thank jg352 for reporting the bug. I will have a fixed released soon.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: install update fails » Update fails to 1.14
Version: 7.x-1.14 » 7.x-1.x-dev
Issue summary: View changes

@bluegeek9 that same update hook looks like an infinite loop or something, but I'm seeing this error which is correct $packed it doesn't exist.

[warning]
Undefined variable $packed visitors.install:170

Maybe it was supposed to be "$ip_address"?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Priority: Major » Critical

Going to bump to critical because that update hook could do some damage considering it's updating the db with wrong data.

bluegeek9’s picture

bluegeek9 commented
Status: Active » Needs review
StatusFileSize
new 3318816-update-fail-6.patch1.37 KB

I am testing this patch before making a new release.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Thanks @bluegeek, the update took 5min (on my fast M1 mac). The good news, it completes without error!

Maybe consider not running the db_update when there is no change? Or limiting the search? Just a thought but testing those two didn't yield much faster results because they all need to change...

Anyways, thank you again!
I'll let @jg352 RTBC, but otherwise I'd commit the change and make a release as soon as you can.

bluegeek9 opened merge request !62

  • bluegeek9 committed 3af7b5c on 7.x-1.x 
    Issue #3318816 by bluegeek9: Update fails to 1.14
bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned
Status: Needs review » Fixed

Added if statement to skip if the address is already valid.

  • bluegeek9 committed 7c873c3 on 7.x-1.x 
    Issue #3318816 by bluegeek9: Update fails to 1.14

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.